[lld] r325713 - [mips][lld] Address post commit review nit.

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 12:01:43 PST 2018


Author: sdardis
Date: Wed Feb 21 12:01:43 2018
New Revision: 325713

URL: http://llvm.org/viewvc/llvm-project?rev=325713&view=rev
Log:
[mips][lld] Address post commit review nit.

Address @ruiu's post commit review comment about a value which is intended
to be a unsigned 32 bit integer as using uint32_t rather than unsigned.

Modified:
    lld/trunk/ELF/Arch/Mips.cpp

Modified: lld/trunk/ELF/Arch/Mips.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Arch/Mips.cpp?rev=325713&r1=325712&r2=325713&view=diff
==============================================================================
--- lld/trunk/ELF/Arch/Mips.cpp (original)
+++ lld/trunk/ELF/Arch/Mips.cpp Wed Feb 21 12:01:43 2018
@@ -331,9 +331,8 @@ void MIPS<ELFT>::writePlt(uint8_t *Buf,
     return;
   }
 
-  unsigned JrInst =
-      isMipsR6() ? (Config->ZHazardplt ? 0x03200409 : 0x03200009)
-                 : (Config->ZHazardplt ? 0x03200408 : 0x03200008);
+  uint32_t JrInst = isMipsR6() ? (Config->ZHazardplt ? 0x03200409 : 0x03200009)
+                               : (Config->ZHazardplt ? 0x03200408 : 0x03200008);
 
   write32<E>(Buf, 0x3c0f0000);     // lui   $15, %hi(.got.plt entry)
   write32<E>(Buf + 4, 0x8df90000); // l[wd] $25, %lo(.got.plt entry)($15)




More information about the llvm-commits mailing list