[lld] r325679 - [ELF] Add -nopie alias for -no-pie (PR36423)

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 05:54:26 PST 2018


Author: hans
Date: Wed Feb 21 05:54:26 2018
New Revision: 325679

URL: http://llvm.org/viewvc/llvm-project?rev=325679&view=rev
Log:
[ELF] Add -nopie alias for -no-pie (PR36423)

In r324043, --nopie was renamed to --no-pie to presumably fix a typo.

As it turns out, "nopie" wasn't a typo but the spelling used by
OpenBSD's binutils ld. Gold on the other hand spells the flag "no-pie".
(Vanilla binutils doesn't have a flag like this at all.)

Since they do the same thing, let's support both spellings.

Modified:
    lld/trunk/ELF/Options.td
    lld/trunk/test/ELF/pie.s

Modified: lld/trunk/ELF/Options.td
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=325679&r1=325678&r2=325679&view=diff
==============================================================================
--- lld/trunk/ELF/Options.td (original)
+++ lld/trunk/ELF/Options.td Wed Feb 21 05:54:26 2018
@@ -358,6 +358,7 @@ def alias_format_b: S<"b">, Alias<format
 def alias_library: JoinedOrSeparate<["-"], "l">, Alias<library>;
 def alias_library_path: JoinedOrSeparate<["-"], "L">, Alias<library_path>;
 def alias_no_pie_pic_executable: F<"no-pic-executable">, Alias<no_pie>;
+def alias_nopie: F<"nopie">, Alias<no_pie>;
 def alias_omagic: Flag<["-"], "N">, Alias<omagic>;
 def alias_o_output: Joined<["--"], "output=">, Alias<o>;
 def alias_o_output2 : Separate<["--"], "output">, Alias<o>;

Modified: lld/trunk/test/ELF/pie.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/pie.s?rev=325679&r1=325678&r2=325679&view=diff
==============================================================================
--- lld/trunk/test/ELF/pie.s (original)
+++ lld/trunk/test/ELF/pie.s Wed Feb 21 05:54:26 2018
@@ -47,9 +47,11 @@
 
 # CHECK:         Type: PT_DYNAMIC
 
-## Check -nopie
+## Check -no-pie
 # RUN: ld.lld -no-pie %t1.o -o %t2
 # RUN: llvm-readobj -file-headers -r %t2 | FileCheck %s --check-prefix=NOPIE
+# RUN: ld.lld -nopie %t1.o -o %t2
+# RUN: llvm-readobj -file-headers -r %t2 | FileCheck %s --check-prefix=NOPIE
 # RUN: ld.lld -no-pic-executable %t1.o -o %t2
 # RUN: llvm-readobj -file-headers -r %t2 | FileCheck %s --check-prefix=NOPIE
 # NOPIE-NOT: Type: SharedObject




More information about the llvm-commits mailing list