[PATCH] D42516: [llvm-objcopy] Add support for large indexes

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich updated this revision to Diff 135194.
jakehehrlich added a comment.

Hey I'm back!

This change fixes previous comments by James and adds a test. Other tests that are needed yet still

1. Make sure section index table is removed when not needed
2. Make sure section index table is added when it is needed
3. Check error for binary output
4. Check initialization errors for section index table
5. To the existing test add checks for the appropriate fields for section index table
6. Check error for case when symbol has SHN_XINDEX index but not

If you can think of more tests please inform.


Repository:
  rL LLVM

https://reviews.llvm.org/D42516

Files:
  test/tools/llvm-objcopy/many-sections.S
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42516.135194.patch
Type: text/x-patch
Size: 18910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180221/18b533df/attachment.bin>