[PATCH] D43028: Add DBG_VALUE support to the linear DAG scheduler

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 17:17:53 PST 2018


aprantl added inline comments.


================
Comment at: test/CodeGen/Generic/linear-dbg-value.ll:29
+; CHECK: DBG_VALUE
+; CHECK-SAME: !14, !17,
+; CHECK: DBG_VALUE
----------------
It would be better to write this as

```
CHECK: DBG_VALUE ![[X:[0-9]+]], ![[EXPR:[0-9]+]]
CHECK: [[EXPR]] = !DIExpression()
...
```

etc. Hard-coding the metadata numbering is just asking for trouble :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D43028





More information about the llvm-commits mailing list