[PATCH] D43070: Add an instruction to avoid cgo compilation error from Go 1.9.4

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 15:15:21 PST 2018


echristo added a comment.

In https://reviews.llvm.org/D43070#1007035, @rhysd wrote:

> In https://reviews.llvm.org/D43070#1006893, @echristo wrote:
>
> > Another thought here is getting that flag put into the default set that's allowed in go?
>
>
> Not allowed. The white list must be set by user for now by the environment variable.
>
> Improving the default white list of options is now ongoing. But I'm not sure whether or not `-Wl,-search_paths_first` and `-Wl,-headerpad_max_install_names` will be in the list.
>
> https://github.com/golang/go/issues/23749


It looks like they've been set into the default set here:  https://go-review.googlesource.com/c/go/+/94676

Do we still need this?

-eric


Repository:
  rL LLVM

https://reviews.llvm.org/D43070





More information about the llvm-commits mailing list