[llvm] r325432 - Fix unused variable warning. NFCI.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 09:00:22 PST 2018


If you don't need the cast result - maybe use isa<> instead?

On Sat, Feb 17, 2018 at 5:50 AM Simon Pilgrim via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: rksimon
> Date: Sat Feb 17 05:48:23 2018
> New Revision: 325432
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325432&view=rev
> Log:
> Fix unused variable warning. NFCI.
>
> We were casting to AArch64InstrInfo but only using it for static methods
> which some compilers complain about.
>
> Modified:
>     llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp
>
> Modified: llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp?rev=325432&r1=325431&r2=325432&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp (original)
> +++ llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp Sat Feb 17
> 05:48:23 2018
> @@ -27,7 +27,6 @@ static bool shouldScheduleAdjacent(const
>                                     const TargetSubtargetInfo &TSI,
>                                     const MachineInstr *FirstMI,
>                                     const MachineInstr &SecondMI) {
> -  const AArch64InstrInfo &II = static_cast<const AArch64InstrInfo&>(TII);
>    const AArch64Subtarget &ST = static_cast<const AArch64Subtarget&>(TSI);
>
>    // Assume wildcards for unspecified instrs.
> @@ -66,7 +65,7 @@ static bool shouldScheduleAdjacent(const
>        case AArch64::BICSWrs:
>        case AArch64::BICSXrs:
>          // Shift value can be 0 making these behave like the "rr"
> variant...
> -        return !II.hasShiftedReg(*FirstMI);
> +        return !AArch64InstrInfo::hasShiftedReg(*FirstMI);
>        case AArch64::INSTRUCTION_LIST_END:
>          return true;
>        }
> @@ -108,7 +107,7 @@ static bool shouldScheduleAdjacent(const
>        case AArch64::BICWrs:
>        case AArch64::BICXrs:
>          // Shift value can be 0 making these behave like the "rr"
> variant...
> -        return !II.hasShiftedReg(*FirstMI);
> +        return !AArch64InstrInfo::hasShiftedReg(*FirstMI);
>        case AArch64::INSTRUCTION_LIST_END:
>          return true;
>        }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180220/bae0a689/attachment.html>


More information about the llvm-commits mailing list