[PATCH] D41278: [MachineCombiner] Improve debug output (NFC)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 05:33:46 PST 2018


Just committing it is fine I think. thanks!

________________________________________
From: Simon Pilgrim via Phabricator <reviews at reviews.llvm.org>
Sent: Tuesday, February 20, 2018 12:31:09 PM
To: andrew.v.tischenko at gmail.com; llvm-dev at redking.me.uk; spatel at rotateright.com; dtemirbulatov at gmail.com; Florian Hahn; hans at chromium.org; sebpop.llvm at gmail.com; ghoflehner at apple.com
Cc: llvm-commits at lists.llvm.org; psd+llvm at pdouglas.net; jdevlieghere at apple.com; junbuml at codeaurora.org
Subject: [PATCH] D41278: [MachineCombiner] Improve debug output (NFC)

RKSimon added a comment.

In https://reviews.llvm.org/D41278#1008470, @avt77 wrote:

> > MachineCombiner part LGTM now. I still would prefer if you submit it without the change in lib/CodeGen/MachineInstr.cpp and do that in a separate change.
>
> OK, I'll do it as a separate patch.


AFAICT the MachineCombiner.cpp part landed at https://reviews.llvm.org/rL325217 - @fhahn are you happy for the MachineInstr.cpp diff just to be committed or do you want @avt77 to raise another phab?


https://reviews.llvm.org/D41278





More information about the llvm-commits mailing list