[PATCH] D43373: [SCEV][NFC] Factor out common logic into a separate method

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 02:29:48 PST 2018


mkazantsev added inline comments.


================
Comment at: include/llvm/Analysis/ScalarEvolution.h:838
+  /// Test if the condition described by Pred, LHS, RHS is known to be true on
+  /// every iteration of the loop of the recurrency LHS.
+  bool isKnownOnEveryIteration(ICmpInst::Predicate Pred,
----------------
sanjoy wrote:
> How about calling this `isKnownViaInduction`?
You are right, current implementation only proves via induction, but I plan a follow-up change https://reviews.llvm.org/D43375 which proves via monotonicity and not induction. So let's keep it as is.


https://reviews.llvm.org/D43373





More information about the llvm-commits mailing list