[PATCH] D43080: Adding Msan support to FreeBSD

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_tls_get_addr.cc:145
 void DTLS_on_libc_memalign(void *ptr, uptr size) {}
-DTLS::DTV *DTLS_on_tls_get_addr(void *arg, void *res) { return 0; }
+DTLS::DTV *DTLS_on_tls_get_addr(void *arg, void *res,
+  unsigned long, unsigned long) { return 0; }
----------------
devnexen wrote:
> krytarowski wrote:
> > This code path shouldn't be used by FreeBSD.
> It does not :-) just put proper signature.
Please use a separate patch.
And it general this patch has a lot of independent changes which should be set as separate patches.


================
Comment at: test/msan/textdomain.cc:3
 // UNSUPPORTED: netbsd, freebsd
+// XFAIL: freebsd
 
----------------
freebsd is in both, unsupported and xfail. Please use just one.


================
Comment at: test/msan/tls_reuse.cc:4
 // Check that when TLS block is reused between threads, its shadow is cleaned.
+// UNSUPPORTED: freebsd
 
----------------
Could you please add comments for all new unsupported with explanation why?
XFAIL is OK without comment. Maybe someone will make them pass later.
If there is possibility to make UNSUPPORTED test work, please consider marking them as XFAIL.




https://reviews.llvm.org/D43080