[PATCH] D43496: [WebAssembly] Split addDefined into two different methods. NFC.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 20:21:18 PST 2018


ruiu added inline comments.


================
Comment at: wasm/SymbolTable.cpp:150
+
+static bool shouldReplace(const Symbol &Existing, const NewSymbol &New) {
   bool Replace = false;
----------------
We can just pass File, Flags, Chunk and IsFunction to this class, then we don't need NewSymbol class, no?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43496





More information about the llvm-commits mailing list