[PATCH] D43271: [Sparc] Include __tls_get_addr in symbol table for TLS calls to it

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 13:35:17 PST 2018


JDevlieghere added a comment.

A small nit but otherwise no objections from my part.



================
Comment at: lib/Target/Sparc/MCTargetDesc/SparcMCExpr.cpp:198
+  case VK_Sparc_TLS_LDM_CALL: {
+    // The corresponding relocations reference __tls_get_addr, as they call it,
+    // but this is only implicit; there is no connection in the ELF file
----------------
Could you make this comment a little more concise and move the rest of the explanation/motivation (as well as the link to the PR) part of the commit message?


Repository:
  rL LLVM

https://reviews.llvm.org/D43271





More information about the llvm-commits mailing list