[PATCH] D43165: [lit] Fix problem in how Python versions open files with different encodings

[Zachary Turner via llvm-commits]

Are we using difflib to try to diff 2 binary files? Could those test be
rewritten to explicitly request a binary diff?
On Mon, Feb 19, 2018 at 11:57 AM Aaron Smith via Phabricator <
reviews at reviews.llvm.org> wrote:

> asmith added a comment.
>
> Hi MatzeB,
>
> We don't have any other ideas for how to fix this and I'm wondering if you
> are okay with committing this so that the lldb unit tests will pass on
> Windows (with a few more changes)?
>
> I can commit this change, or I can commit a different change that catches
> the exception when open fails and reopens in 'Latin-1', or we can try
> something else like marking the tests as XFAIL on Windows and letting the
> original authors fix them.
>
> Aaron
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D43165
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180219/09504808/attachment.html>