[PATCH] D41298: [Dominators] Remove verifyDomTree and add some verifying for Post Dom Trees

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 08:40:31 PST 2018


dmgreen added inline comments.


================
Comment at: include/llvm/Support/GenericDomTree.h:322
     if (Roots.size() != Other.Roots.size())
-      return false;
+      return true;
 
----------------
kuhar wrote:
> dmgreen wrote:
> > Can you check this is correct. This function, unusually, returns false on same, true on different.
> Good catch! Feel free to fix it -- I think you can change this and the next one in a separate commit without review.
Thanks. I'll count that as a review :) https://reviews.llvm.org/rL325517


https://reviews.llvm.org/D41298





More information about the llvm-commits mailing list