[PATCH] D43405: [WebAssembly] Remove unneeded Chunk::getFileName() method. NFC.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 15:58:26 PST 2018

ruiu added a comment.

Good observation, but I think we should use toString() in ELF too. toString() is there for you so that you don't need to construct a string like this, and doing this is error-prone. In this case, if file foo.o is in bar.a, toString generates something like


while this string construction generates a string like

  '.text' in file 'foo.o'

which isn't very helpful if you don't know which file foo.o is in.



More information about the llvm-commits mailing list