[PATCH] D43416: [WebAssembly] Simplify FunctionSymbol get/set/hasFunctionType. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 15:50:01 PST 2018


sbc100 added inline comments.


================
Comment at: wasm/Symbols.h:124-125
 public:
   DefinedFunction(StringRef Name, uint32_t Flags, InputFile *F = nullptr,
-                  InputChunk *C = nullptr)
-      : FunctionSymbol(Name, DefinedFunctionKind, Flags, F, C) {}
+                  InputFunction *Function = nullptr)
+      : FunctionSymbol(Name, DefinedFunctionKind, Flags, F, Function) {}
----------------
ruiu wrote:
> If you do not `= nullptr`, please remove it as well.
Ha.. already did that but hadn't uploaded it yet.  Great minds ..


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43416





More information about the llvm-commits mailing list