[PATCH] D43405: [WebAssembly] Remove unneeded Chunk::getFileName() method. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 15:49:57 PST 2018

sbc100 added a comment.

In https://reviews.llvm.org/D43405#1010999, @ruiu wrote:

> But I believe a better way of doing this kind of stuff is to define toString(InputChunk *). toString() function is a common interface to stringize objects to create debug messages.

But in this case the only user actually wants the filename on its own.. not the string description of the chunk.    (ELF does basically exactly the same thing here BTW)

  rLLD LLVM Linker


More information about the llvm-commits mailing list