[PATCH] D43410: Do not automatically append --full-shutdown to lld tests.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 15:05:49 PST 2018

pcc added a comment.

In https://reviews.llvm.org/D43410#1010826, @ruiu wrote:

> > Isn't --full-shutdown necessary for the leak sanitizer to work correctly?
> Hmm, that's probably true. I believe we do _exit in lld COFF linker. Maybe we should stop doing that as well?

Yes, it would probably be worth adding a /fullshutdown flag and using it in the tests to detect memory leaks. Same for wasm I'd imagine.


More information about the llvm-commits mailing list