[PATCH] D43264: [WebAssembly] Add explicit symbol table

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 13:53:25 PST 2018

ncw added a comment.

In https://reviews.llvm.org/D43264#1009642, @sbc100 wrote:

> I've been trying to do this this evening but its fairly entangled.  I will try again tomorrow, perhaps with a preparatory change to precede it.

Sorry Sam, somehow this didn't catch my eye in my inbox -I realise now we might have been working on the same cleanup :( Oh well, don't worry if you go a different direction to what I did in https://reviews.llvm.org/D43391.

I can't really chat this evening - not that I'd be much help anyway!

If you and Rui can come up with a solution that works for InputGlobal - go ahead and merge! I'll take any solution, I'm only arguing for changes at the moment that are fairly close to how these patches are currently, to so that we don't end up with another big refactor on our hands before we can merge what we've got so far.

Do you have any thoughts at this point on how you think InputGlobal should fit into the hierarchy, eg like the comment in https://reviews.llvm.org/D43391?

  rLLD LLVM Linker


More information about the llvm-commits mailing list