[PATCH] D43399: [WebAssembly] Fix bug is function signature checking

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 11:43:56 PST 2018


sbc100 added a comment.

In https://reviews.llvm.org/D43399#1010561, @ruiu wrote:

> If we can guarantee the invariance by data structure itself, that's better than guaranteeing the same thing by code (which is asserts). Does it make sense to read function type on symbol instantiation time?


Oh I see, or getFunction() can then just return the member, rather than looking at the chunk.  Sure I think that makes sense.  Can we do that a separate change though?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43399





More information about the llvm-commits mailing list