[PATCH] D43021: Recognize all NetBSD architectures in UBSan

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 11:26:53 PST 2018

krytarowski added inline comments.

Comment at: lib/ubsan/ubsan_platform.h:16
 // Other platforms should be easy to add, and probably work as-is.
+#if defined(__linux__) || defined(__FreeBSD__) || defined(__APPLE__) ||        \
vitalybuka wrote:
> Why did you remove CPU check?
> How can we be sure that e.g. Linux on any CPU is going to work?
We already maintain it with CMake rules.

As I understand this was proposed by @ro to just maintain the list of OSes here. I prefer this over the existing situation.

If we want to control CPU types here, I would prefer to split this per OS and check CPU. LINUX || FREEBSD || APPLE || NETBSD working on the same set of CPUs is wrong.



More information about the llvm-commits mailing list