[PATCH] D43397: Bring back r323297.

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 11:05:02 PST 2018

espindola created this revision.
espindola added a reviewer: rnk.

It was reverted because it broke the grub build. The reason the grub build broke is because grub does its own relocation processing and was not handing R_386_PLT32. Since grub has no dynamic linker, the fix is trivial: handle R_386_PLT32 exactly like R_386_PC32.

On the report it was noted that they are using  -fno-integrated-assembler. The upstream GAS (starting with 451875b4f976a527395e9303224c7881b65e12ed) will already be producing a R_386_PLT32 anyway, so they have to update their code one way or the other

Original message:

Don't assume a null GV is local for ELF and MachO.

This is already a simplification, and should help with avoiding a plt
reference when calling an intrinsic with -fno-plt.

With this change we return false for null GVs, so the caller only
needs to check the new metadata to decide if it should use foo at plt or
 *foo at got.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43397.134655.patch
Type: text/x-patch
Size: 8795 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180216/d8f2cc6a/attachment.bin>

More information about the llvm-commits mailing list