[PATCH] D43117: [zorg] Cleanup unnecessary options for ARM and AArch64 bots
Maxim Kuvyrkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 16 03:59:04 PST 2018
maxim-kuvyrkov accepted this revision.
maxim-kuvyrkov added a comment.
This revision is now accepted and ready to land.
I'll amend libcxx and global-isel builders per comments in the final commit. Changes for all other bots seem to be OK.
Comment at: buildbot/osuosl/master/config/builders.py:1290
> maxim-kuvyrkov wrote:
> > rengolin wrote:
> > > maxim-kuvyrkov wrote:
> > > > rengolin wrote:
> > > > > why disabling marm/mthumb here?
> > > > This is a single-stage build, so CMAKE_C_FLAGS and CMAKE_CXX_FLAGS are passed only to host compiler. AFAICT, they do not affect results of libcxx testsuites.
> > > The host compiler will compile libcxx with arm/thumb and therefore generate different library code, no? Same for test code.
> > Yes and no. Library and test code will be different bit-wise, but (unless there are "#ifdef __arm__ / #ifdef __thumb__" !) should be semantically equivalent.
> > If there are indeed different code paths for ARM / Thumb modes or other architectural features, then, "yes", we should differentiate here.
> I don't know, but I wouldn't assume so. I think we can leave that change for a different patch, after asking the libc++ folks.
OK, sounds good.
More information about the llvm-commits