[compiler-rt] r325240 - Add Xray instrumentation support to FreeBSD

[via llvm-commits]

Hi Kamil, that patch seems to work for me.

Douglas Yung

> -----Original Message-----
> From: Kamil Rytarowski [mailto:n54 at gmx.com]
> Sent: Thursday, February 15, 2018 18:14
> To: Yung, Douglas; devnexen at gmail.com
> Cc: llvm-commits at lists.llvm.org
> Subject: Re: [compiler-rt] r325240 - Add Xray instrumentation support to
> FreeBSD
> 
> I've reverted it and the test has been passed successfully
> 
> PASS: XRay-x86_64-linux :: TestCases/Linux/quiet-start.cc (39620 of 41131)
> 
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-
> fast/builds/8018/steps/test/logs/stdio
> 
> Could you please test this patch:
> 
> http://netbsd.org/~kamil/llvm/xray-lit-freebsd.txt
> 
> It will reintroduce FreeBSD support with a less invasive way.
> 
> On 16.02.2018 02:07, douglas.yung at sony.com wrote:
> > Hi,
> >
> > Reverting the changes in lit.cfg do seem to fix the test on my machine. Can
> you commit the revert to the lit.cfg?
> >
> > Douglas Yung
> >
> >> -----Original Message-----
> >> From: Kamil Rytarowski [mailto:n54 at gmx.com]
> >> Sent: Thursday, February 15, 2018 16:50
> >> To: Yung, Douglas; devnexen at gmail.com
> >> Cc: llvm-commits at lists.llvm.org
> >> Subject: Re: [compiler-rt] r325240 - Add Xray instrumentation support
> >> to FreeBSD
> >>
> >> On 16.02.2018 01:26, douglas.yung at sony.com wrote:
> >>> Hi David,
> >>>
> >>> I believe that this change is causing the test "XRay-x86_64-linux ::
> >> TestCases/Linux/quiet-start.cc" to fail on the build bot
> >> llvm-clang-lld- x86_64-debian-fast. You can see the test failure in
> >> the run at
> >> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-
> >> fast/builds/8008/. Can you take a look and fix the problem?
> >>>
> >>> Douglas Yung
> >>>
> >>
> >> Does reverting changes just in lit.cfg work?
> >>
> >> http://llvm.org/viewvc/llvm-project/compiler-
> >> rt/trunk/test/xray/lit.cfg?r1=325240&r2=325239&pathrev=325240
> >
>