[PATCH] D36351: [lld][ELF] Add profile guided section layout

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 15:50:13 PST 2018

On Thu, Feb 1, 2018 at 2:12 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Peter Collingbourne <peter at pcc.me.uk> writes:
> > These are the results that I previously got with chrome:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=759259#c10
> Cool. You mention local symbols, so I assume that you were using the
> older patch version that read the call graph from a text file, right?


Handling ICF is a nice improvement. Would you mind sending a patch that
> adds that to the current version of the patch?

The patch has changed significantly since I last looked at it, but at the
time it was only a matter of looking through the Repl pointer. I think you
should be able to replace "SymbolSection[D->getName()] = IS;" with
"SymbolSection[D->getName()] = IS->Repl;" in your latest patch.

Is there documentation somewhere on how to run these benchmarks? If not,
> would you mind running them again once ICF added to this patch?

Unfortunately the documentation for running chromium benchmarks with
profiling is not great. I will try to find some time soon to redo the
benchmarks with the latest patch.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180215/ccbcbac6/attachment.html>

More information about the llvm-commits mailing list