[PATCH] D43314: [lit] - Allow 1 test to report multiple micro-test results to provide support for microbenchmarks.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 14:16:38 PST 2018

rengolin added inline comments.

Comment at: utils/lit/lit/main.py:130
+            for key, micro_test in test.result.microResults.items():
+                micro_full_name = test.getFullName()[:-5] + '/' + key + ".test"
homerdin wrote:
> homerdin wrote:
> > rengolin wrote:
> > > What's with the [:-5] ?
> > I changed the way I build the name to be clearer.  Was using [:-5] (.test) to expand the parent test name with the micro test name before ".test" 
> Realizing this is incorrect as it only works with ".test" files.  Need a safer way to expand the test name.
regular expression would do nicely


More information about the llvm-commits mailing list