[PATCH] D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 14:10:51 PST 2018

dblaikie added a comment.

In https://reviews.llvm.org/D42937#1008337, @wolfgangp wrote:

> I'm still producing the dwo files from IR, I could turn those into assembly files as well, if that's preferable.

I think it'd probably be better - could you explain what the motivation is for them being IR tests? (what's the different needs there compared to the assembly test cases?)

Comment at: test/tools/llvm-dwp/Inputs/string_offsets/mixed_dwp.s:1-4
+# Test object in dwp format to verify that llvm-dwp correctly handles DWARF v5 string
+# offset tables. We have 2 CUs and 2 TUs, one each of version 5 and version 4.
+# Note that the CUs' contributions to the string offsets table are not in the same
+# order as the order in which the CUs are listed in the index table.
Worth having repro steps here? (original source, commands used to produce it, including describing the manual steps used to reorder sections)

Should this comment explain why the string offset contributions are reordered? Might help - though probably want to explain it in the test file too.

Also perhaps it'd be easier if the string_offsets.test file were split (there aren't that many "BOTH" lines - might be easier to read as two separate tests rather than trying to have pieces in common?) & then this mixed_dwp.s could be its own test with the RUN/CHECK lines written in the file directly, rather than split over two files?


More information about the llvm-commits mailing list