[PATCH] D43337: [CodeGen] Don't omit any redundant information in -debug output when asserts are enabled

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 11:11:10 PST 2018

MatzeB added a comment.

In https://reviews.llvm.org/D43337#1009059, @thegameg wrote:

> In https://reviews.llvm.org/D43337#1009040, @MatzeB wrote:
> > Printing different things depending on whether asserts are enabled feels strange. Can you explain the motivation here?
> I think we should be showing all the information we have (redundant reg classes, redundant successors, predecessors (always redundant)) in things like -print-after-all, or when calling MF.dump() from the debugger (basically, when we're actually debugging llvm). Also, this can be too verbose to have when calling MF.print() for testing or other purposes.
>  I'm basically trying to come up with an implicit -simplify-mir for MF.print().
> I guess if we don't really care about having MF.print() being too verbose, we could always assume IsStandalone is true except for MIR printing.

Apparently you care about print() being more verbose (I didn't print too much from a debugger/print-after-all lately, so maybe I am just unaware that reducing information is annoying there).
I'd say go for that independently of the asserts then (but keep it reduced for MIR printing).


More information about the llvm-commits mailing list