[PATCH] D43201: [X86] Only reorder srl/and on last DAG combiner run

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 08:40:56 PST 2018


spatel added a comment.

In https://reviews.llvm.org/D43201#1008837, @craig.topper wrote:

> All valid points. I don't know of any benchmarks that care either. I guess my goal with this patch is to get DAG going into isel to be consistent. The test cases in test-shrink.ll look very similar, but some use test and some use bt. This patch gets them all back to using test. We can isel them back to bt for https://reviews.llvm.org/D37418.


Yes, I'm all for more consistency; it's a mess.

If I'm seeing it correctly, https://reviews.llvm.org/D37418 would need to be enhanced to handle these cases because it's only looking for 64-bit constants right now?

So let's try to move these forward. AFAICT, there's no opposition to https://reviews.llvm.org/D37418 with -Os. Start there?


https://reviews.llvm.org/D43201





More information about the llvm-commits mailing list