[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

[Ilya Biryukov via llvm-commits]

Sorry about that, fixed in r325254.
I keep hitting this MSVC compilation error all the time.


On Thu, Feb 15, 2018 at 4:26 PM Carlos Alberto Enciso via Phabricator <
reviews at reviews.llvm.org> wrote:

> CarlosAlbertoEnciso added a comment.
>
> Hi,
>
> It seems that your submission broke the Windows/Linux builds for 'clangd'.
>
> The generated error message is:
>
>   C:\Program Files (x86)\Microsoft Visual Studio
> 14.0\VC\include\future(263): error C2512:
> 'llvm::Expected<std::vector<clang::tooling::Replacement,std::allocator<_Kty>>>':
> no appropriate default constructor available
> [C:\j\w\opensource\opensource_to_sce_merge\build\tools\clang\tools\extra\unittests\clangd\ClangdTests.vcxproj]
>
>   C:\xxx\llvm\tools\clang\tools\extra\clangd\ClangdServer.h(231): note:
> see declaration of
> 'llvm::Expected<std::vector<clang::tooling::Replacement,std::allocator<_Kty>>>'
>   C:\Program Files (x86)\Microsoft Visual Studio
> 14.0\VC\include\future(255): note: while compiling class template member
> function
> 'std::_Associated_state<_Ty>::_Associated_state(std::_Deleter_base<_Ty> *)'
>   C:\Program Files (x86)\Microsoft Visual Studio
> 14.0\VC\include\future(1491): note: see reference to function template
> instantiation
> 'std::_Associated_state<_Ty>::_Associated_state(std::_Deleter_base<_Ty> *)'
> being compiled
>   C:\Program Files (x86)\Microsoft Visual Studio
> 14.0\VC\include\future(989): note: see reference to class template
> instantiation 'std::_Associated_state<_Ty>' being compiled
>   C:\Program Files (x86)\Microsoft Visual Studio
> 14.0\VC\include\future(987): note: while compiling class template member
> function 'bool std::_State_manager<_Ty>::valid(void) throw() const'
>
> Thanks
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D43227
>
>
>
>

-- 
Regards,
Ilya Biryukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180215/945e1b23/attachment.html>