[PATCH] D43330: [gtest] Add PrintTo overload for StringRef.

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 04:59:05 PST 2018


sammccall added a comment.

FWIW I'm fine with putting it in `StringRef.h` or here, (`custom/gtest-printers.h`is strictly better than here though).

While I like `llvm/Testing` in principle, the fact that the test compiles and runs fine if you forget to include it, and just gives terrible error messages when it starts failing, seems like a recipe for disaster.


Repository:
  rL LLVM

https://reviews.llvm.org/D43330





More information about the llvm-commits mailing list