[PATCH] D43330: [gtest] Add PrintTo overload for StringRef.

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 03:02:06 PST 2018


labath added subscribers: zturner, labath.
labath added a comment.

This code does not have to live directly inside gtest. As such, maybe a better place for it would be somewhere under `include/llvm/Testing` ? (We already have `PrintTo` functions for `Error` and `Expected` there..)

The reason I'm mentioning this is that while StringRef is a fairly basic class, I'm sure other classes would benefit from being GTEST-ified as well, and shoving them all somewhere into third party code sounds like a bad idea...


Repository:
  rL LLVM

https://reviews.llvm.org/D43330





More information about the llvm-commits mailing list