[PATCH] D43175: [SCEV] Favor isKnownViaSimpleReasoning over constant ranges check

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 22:03:22 PST 2018

mkazantsev added inline comments.

Comment at: lib/Analysis/ScalarEvolution.cpp:8962
-  if (isKnownPredicateViaConstantRanges(Pred, LHS, RHS))
+  if (isKnownViaSimpleReasoning(Pred, LHS, RHS))
     return true;
sanjoy wrote:
> I think it is better to call this `isKnownViaNonRecursiveReasoning` since "simple" is not very descriptive (if you agree can you please directly land that in a subsequent change?).
Will do as follow-up NFC.

Comment at: test/Transforms/IndVarSimplify/loop-invariant-conditions.ll:144
 !0 = !{i64 0, i64 100}
sanjoy wrote:
> Let's move this to the bottom of the file.
Will do as follow-up.


More information about the llvm-commits mailing list