[PATCH] D43278: Add Xray instrumentation support to FreeBSD

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 17:10:18 PST 2018

krytarowski added inline comments.

Comment at: lib/xray/xray_utils.cc:20
+#include <sys/thr.h>
krytarowski wrote:
> I assume that we can drop changes from this file.
> While there, FreeBSD's implementation of GetTid() in sanitizer is `pthread_self()`.
> It looks incorrect to me as it returns a pointer to an internal `struct pthread` type. I would consider switching it to `thr_self(2)`.
The common_sanitizer part can be done with a separate revision.


More information about the llvm-commits mailing list