[PATCH] D43278: Add Xray instrumentation support to FreeBSD

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 14:02:31 PST 2018


krytarowski added inline comments.


================
Comment at: lib/xray/tests/unit/fdr_logging_test.cc:160
     std::thread t{[I, &Threads] {
       fdrLoggingHandleArg0(I + 1, XRayEntryType::ENTRY);
----------------
Missing context.. but Threads is defined as: `std::array<pid_t, 2> Threads;`

Shouldn't this be `Tid_t` or `uint64_t`?


https://reviews.llvm.org/D43278





More information about the llvm-commits mailing list