[PATCH] D43278: Add Xray instrumentation support to FreeBSD

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 09:51:44 PST 2018

devnexen added inline comments.

Comment at: lib/xray/xray_x86_64.cc:84
+    if (sysctlbyname("machdep.tsc_freq", &TSCFrequency, &tscfreqsz,
+        NULL, 0) != -1) {
krytarowski wrote:
> I think you should use `sysctl()`, as `sysctlbyname()` allocates memory internally.
It s not instrumented part, plus did not find sysctl counterpart for this one.


More information about the llvm-commits mailing list