[PATCH] D42717: [JumpThreading] sync DT for LVI analysis (PR 36133)

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 08:31:45 PST 2018

brzycki added a comment.

In https://reviews.llvm.org/D42717#1007270, @a.elovikov wrote:

> I might be missing something, but why don't we enable DT back in LVI after the JT pass finishes and flushes the DDT? Is it possible that we end up with disabled DT *after* the JT?

I missed that, thank you @a.elovikov . I'm adding it to the next patch revision.

Comment at: llvm/lib/Analysis/LazyValueInfo.cpp:469
+    void disableDT() {
+      if (DT)
+        std::swap(DT, DisabledDT);
a.elovikov wrote:
> I'd add 
>   assert((!DT || !DisabledDT) && "Both DT and DisabledDT are not nullptr!")
Good point, will add asserts.


More information about the llvm-commits mailing list