[PATCH] D42948: [SelectionDAG] Support some SimplifySetCC cases for comparing against vector splats of constants.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 08:21:01 PST 2018

spatel added a comment.

In https://reviews.llvm.org/D42948#1007109, @craig.topper wrote:

> Add directed tests. I believe there are some missing optimizations due to not enabling canonicalization of GE/LE to GT/LT for vectors.

We might have to be more careful with vector ISAs because they tend to leave out the full set of predicates. Ie, do we have to check for legal-or-custom if this transform can happen late, or can we assume that all predicates must be handled for all data types?

I checked in the baseline tests at https://reviews.llvm.org/rL325138 - can you rebase here, so we just see the improvements?



More information about the llvm-commits mailing list