[PATCH] D43291: [ARM] f16 vcmp fixes

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: test/CodeGen/ARM/fp16-instructions.ll:126
 
 ; CHECK-SOFTFP-FULLFP16-NOT:  vmov.f16  s{{.}}, r0
 ; CHECK-SOFTFP-FULLFP16-NOT:  vmov.f16  s{{.}}, r1
----------------
Should this be testing CHECK-HARDFP-FULLFP16-NOT instead?


================
Comment at: test/CodeGen/ARM/fp16-instructions.ll:132
 ; 4. VCMPE
+define i32 @VCMPE_IMM(float %F.coerce) {
+entry:
----------------
Do we need a VCMP_IMM test too? Or am I missing something?


https://reviews.llvm.org/D43291