[PATCH] D43234: [ELF] - Fix case of using both --icf and --symbol-ordering-file together.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 17:55:25 PST 2018

ruiu added a comment.

I think that this patch isn't necessarily wrong but perhaps not desirable. Why did you pick the highest priority instead of the lowest priority, for example? The stuff you want to achieve with --symbol-ordering-file is to force some layout, and if your file contains duplicate entries due to ICF, you can't achieve your goal.

I think that you create a symbol ordering file from profiler output. COMDAT names that the profiler uses is the one that is selected by ICF, no? So, the generated symbol ordering file naturally uses the COMDAT names that were selected by ICF. So I don't think we need to do anything about it.


More information about the llvm-commits mailing list