[PATCH] D43112: [WebAssembly] Use Symbol class heirarchy. NFC.

[Sam Clegg via Phabricator via llvm-commits]

sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: wasm/SymbolTable.cpp:164
 
-Symbol *SymbolTable::addDefined(StringRef Name, Symbol::Kind Kind,
-                                uint32_t Flags, InputFile *F, InputChunk *Chunk,
+Symbol *SymbolTable::addDefined(bool IsFunction, StringRef Name, uint32_t Flags,
+                                InputFile *F, InputChunk *Chunk,
----------------
ruiu wrote:
> It is not clear to me why we need addDefined function even though we have addDefinedFunction and addDefinedGlobal functions. What is this for?
Renamed to reflect their purpose .. addSyntheticGlobal etc..


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43112