[PATCH] D35267: Pass Divergence Analysis data to selection DAG to drive divergence dependent instruction selection

Alexander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 06:30:21 PST 2018

alex-t added inline comments.

Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:794
+            return true;
+          return DA->isDivergent(FLI->getValueFromVirtualReg(Reg));
+        }
rampitec wrote:
> !DA || DA->isDivergent(...)
> You are using getAnalysisIfAvailable, so it can be missing.
if DA == nulptr in the case above we'd return ((bool)!DA) true?

maybe it's better return false for the targets that have no DA?

I mean " DA && DA->isDivegent()" if we have no DA we return false. In case we have, the returned value will be defined by the isDivergent result


More information about the llvm-commits mailing list