[PATCH] D42717: [JumpThreading] sync DT for LVI analysis (PR 36133)

Andrei Elovikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 01:45:55 PST 2018

a.elovikov added inline comments.

Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:648
+    LVI->enableDT();
     return !Result.empty();
Isn't it strange that we enable LVI without flushing DDT first? Even if it's ok now I'm afraid it might become a source of nasty bugs in the future.

And related question - would it be better to integrate the LVI->disableDT/enableDT calls into the DDT itself (or a wrapper around it)? So that any deferred update to the DT would automatically make DT disabled in LVI and every flush would make it enabled?


More information about the llvm-commits mailing list