[PATCH] D43214: [X86] Use EDI for retpoline when no scratch regs are left

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

So, if I understand correctly, this prevents the use of `-mregparm=3`, 32-bit x86, and a caller-save-all calling convention. And the reason this is reliable is because LLVM doesn't have such a calling convention (except maybe AnyReg) and if someone even managed to craft such IR they would just hit the assert and have to extend this? And we believe Clang definitively cannot create such a calling convention?

I'm not doubting anything here, I'm repeating to check my understanding. =]

Provided I've understood correctly, LGTM, let's get this in testing.


https://reviews.llvm.org/D43214