[PATCH] D42710: [SafeStack] Use updated CreateMemCpy API to set more accurate source and destination alignments.

[Daniel Neilson via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL324955: [SafeStack] Use updated CreateMemCpy API to set more accurate source and… (authored by dneilson, committed by ).

Repository:
  rL LLVM

https://reviews.llvm.org/D42710

Files:
  llvm/trunk/lib/CodeGen/SafeStack.cpp
  llvm/trunk/lib/CodeGen/SafeStackLayout.cpp
  llvm/trunk/lib/CodeGen/SafeStackLayout.h
  llvm/trunk/test/Transforms/SafeStack/X86/byval.ll


Index: llvm/trunk/test/Transforms/SafeStack/X86/byval.ll
===================================================================
--- llvm/trunk/test/Transforms/SafeStack/X86/byval.ll
+++ llvm/trunk/test/Transforms/SafeStack/X86/byval.ll
@@ -33,6 +33,23 @@
   ret i32 %0
 }
 
+; Unsafe access to a byval argument.
+; Argument is copied to the unsafe stack.
+; Check that dest align of memcpy is set according to datalayout prefered alignment
+define i32 @ByValUnsafe2(%struct.S* byval nocapture readonly %zzz, i64 %idx) norecurse nounwind readonly safestack uwtable {
+entry:
+  ; CHECK-LABEL: @ByValUnsafe
+  ; CHECK: %[[A:.*]] = load {{.*}} @__safestack_unsafe_stack_ptr
+  ; CHECK: store {{.*}} @__safestack_unsafe_stack_ptr
+  ; CHECK: %[[B:.*]] = getelementptr i8, i8* %[[A]], i32 -400
+  ; CHECK: %[[C:.*]] = bitcast %struct.S* %zzz to i8*
+  ; CHECK: call void @llvm.memcpy.p0i8.p0i8.i64(i8* align 8 %[[B]], i8* %[[C]], i64 400, i1 false)
+  ; CHECK: ret i32
+  %arrayidx = getelementptr inbounds %struct.S, %struct.S* %zzz, i64 0, i32 0, i64 %idx
+  %0 = load i32, i32* %arrayidx, align 4
+  ret i32 %0
+}
+
 ; Highly aligned byval argument.
 define i32 @ByValUnsafeAligned(%struct.S* byval nocapture readonly align 64 %zzz, i64 %idx) norecurse nounwind readonly safestack uwtable {
 entry:
Index: llvm/trunk/lib/CodeGen/SafeStack.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/SafeStack.cpp
+++ llvm/trunk/lib/CodeGen/SafeStack.cpp
@@ -557,6 +557,7 @@
 
   for (Argument *Arg : ByValArguments) {
     unsigned Offset = SSL.getObjectOffset(Arg);
+    unsigned Align = SSL.getObjectAlignment(Arg);
     Type *Ty = Arg->getType()->getPointerElementType();
 
     uint64_t Size = DL.getTypeStoreSize(Ty);
@@ -573,7 +574,7 @@
                       DIExpression::NoDeref, -Offset, DIExpression::NoDeref);
     Arg->replaceAllUsesWith(NewArg);
     IRB.SetInsertPoint(cast<Instruction>(NewArg)->getNextNode());
-    IRB.CreateMemCpy(Off, Arg, Size, Arg->getParamAlignment());
+    IRB.CreateMemCpy(Off, Align, Arg, Arg->getParamAlignment(), Size);
   }
 
   // Allocate space for every unsafe static AllocaInst on the unsafe stack.
Index: llvm/trunk/lib/CodeGen/SafeStackLayout.h
===================================================================
--- llvm/trunk/lib/CodeGen/SafeStackLayout.h
+++ llvm/trunk/lib/CodeGen/SafeStackLayout.h
@@ -47,6 +47,7 @@
   SmallVector<StackObject, 8> StackObjects;
 
   DenseMap<const Value *, unsigned> ObjectOffsets;
+  DenseMap<const Value *, unsigned> ObjectAlignments;
 
   void layoutObject(StackObject &Obj);
 
@@ -64,6 +65,9 @@
   /// Returns the offset to the object start in the stack frame.
   unsigned getObjectOffset(const Value *V) { return ObjectOffsets[V]; }
 
+  /// Returns the alignment of the object
+  unsigned getObjectAlignment(const Value *V) { return ObjectAlignments[V]; }
+
   /// Returns the size of the entire frame.
   unsigned getFrameSize() { return Regions.empty() ? 0 : Regions.back().End; }
 
Index: llvm/trunk/lib/CodeGen/SafeStackLayout.cpp
===================================================================
--- llvm/trunk/lib/CodeGen/SafeStackLayout.cpp
+++ llvm/trunk/lib/CodeGen/SafeStackLayout.cpp
@@ -42,6 +42,7 @@
 void StackLayout::addObject(const Value *V, unsigned Size, unsigned Alignment,
                             const StackColoring::LiveRange &Range) {
   StackObjects.push_back({V, Size, Alignment, Range});
+  ObjectAlignments[V] = Alignment;
   MaxAlignment = std::max(MaxAlignment, Alignment);
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42710.133942.patch
Type: text/x-patch
Size: 3544 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180212/25117172/attachment.bin>