[PATCH] D43155: [asan] Add "arm64" into the list of 64-bit architectures

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 13:38:24 PST 2018

kubamracek added a comment.

> Does this patch change which ASan tests get run on arm64?

Yes. Anything that was marked `REQUIRES: asan-64-bits` wasn't being run on arm64, and that's clearly a mistake.

Comment at: test/asan/CMakeLists.txt:21
 macro(get_bits_for_arch arch bits)
-  if (${arch} MATCHES "i386|arm|mips|mipsel")
-    set(${bits} 32)
-  elseif (${arch} MATCHES "x86_64|powerpc64|powerpc64le|aarch64|mips64|mips64el|s390x")
+  if (${arch} MATCHES "x86_64|powerpc64|powerpc64le|aarch64|arm64|mips64|mips64el|s390x")
     set(${bits} 64)
delcypher wrote:
> I wonder if we should avoid using `MATCHES` and use `STREQUAL` instead. This would require listing each supported architecture (i.e. all variants would need to be specified) explicitly. This would avoid accidentally matching architectures in the future. This would bloat the code a bit though.
> This might also be a bit painful for architecture variants that are supported out of tree because they'd now have to patch this macro whereas before it "just worked".
Generally, I agree, but I don't want to do it in this patch. Right now, let's just fix the obvious mistake of matching "arm64" and "mips64" as 32-bit architectures.

  rCRT Compiler Runtime


More information about the llvm-commits mailing list