[PATCH] D43205: [WebAssembly] Fix casting MCSymbol to MCSymbolWasm on ELF

Jacob Gravelle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 12:27:48 PST 2018

jgravelle-google marked an inline comment as done.
jgravelle-google added inline comments.

Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:94
-        getTargetStreamer()->emitImportModule(Sym, Name);
+        getTargetStreamer()->emitImportModule(WasmSym, Name);
dschuff wrote:
> Does emitImportModule do anything for ELF? I assume not, maybe it makes more sense to just explicitly condition this whole thing on `BinFormatWasm` and that way when we remove ELF it will be easy to find all the mentions of BinFormatELF or BinFormatWasm in the backend and remove them.
Yeah it just asserts if we actually do add a "wasm-import-module" attribute. This is less explicitly unsupported, but more refactorable in future.



More information about the llvm-commits mailing list