[PATCH] D43176: [LoopInterchange] Incrementally update the dominator tree.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:465
+
+    AU.addPreserved<DominatorTreeWrapperPass>();
   }
----------------
This list of preserved passes seems really short; at the very least, it should preserve GlobalsAA.  Would be nice to preserve LoopInfo, LCSSA, and ScalarEvolution; I think the pass needs to preserve them anyway to interact correctly with itself?


================
Comment at: test/Transforms/LoopInterchange/reductions.ll:1
-; RUN: opt < %s -basicaa -loop-interchange -S | FileCheck %s
+; RUN: opt < %s -basicaa -loop-interchange -verify-dom-info -S | FileCheck %s
 
----------------
Maybe add verify-dom-info to all the LoopInterchange tests?


https://reviews.llvm.org/D43176