[PATCH] D42846: [PartialInlining] Use isInlineViable to detect constructs preventing inlining.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 11:34:32 PST 2018

efriedma added a comment.

isInlineViable doesn't care whether the code is actually reachable, so you could pessimize partial inlining in certain cases, e.g. a function which calls va_start conditionally.  I don't think we need fix that now, but it would be nice to at least have a testcase demonstrating the issue.


More information about the llvm-commits mailing list