[PATCH] D43201: [X86] Only reorder srl/and on last DAG combiner run

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 10:15:10 PST 2018

craig.topper created this revision.
craig.topper added reviewers: spatel, RKSimon.

This seems to interfere with a target independent brcond combine that looks for the (srl (and X, C1), C2) pattern to enable TEST instructions. Once we flip, that combine doesn't fire and we end up exposing it to the X86 specific BT combine which causes us to emit a BT instruction. BT has lower throughput than TEST.

We could try to make the brcond combine aware of the alternate pattern, but since the flip was just a code size reduction and not likely to enable other combines, it seemed easier to just delay it until after lowering.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43201.133894.patch
Type: text/x-patch
Size: 6121 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180212/943318fb/attachment.bin>

More information about the llvm-commits mailing list