[PATCH] D43132: Fix DataFlowSanitizer instrumentation pass to take parameter position changes into account for custom functions.

Sam Kerner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 12 09:58:18 PST 2018

skerner added a comment.

Peter, thanks for the review!

Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:243
+  /// of F into the third argument of F', then this map will contain (0->2).
+  const llvm::DenseMap<unsigned, unsigned> ArgumentIndexMapping;
pcc wrote:
> I think this can just be a `std::vector<unsigned>`.
I chose a map so that arguments to the original function which are not included in the transformed function can be excluded.  However, I now see that this can not happen.  Changed.



More information about the llvm-commits mailing list